libosmocore[master]: core/conv: do not mix up AVX and SSE code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon May 29 08:18:49 UTC 2017


Patch Set 3: Code-Review-1

(1 comment)

In general, I'd prefer to avoid confusion with generated code which is in files ending with _gen.* as well. Calling it viterbi_generic.c would be much better.

https://gerrit.osmocom.org/#/c/2760/3/src/viterbi_gen.c
File src/viterbi_gen.c:

Line 145: void osmo_conv_gen_metrics_k5_n2_gen(const int8_t *seq, const int16_t *out,
Why the double _gen in the name? And why do we have to rename it at all?


-- 
To view, visit https://gerrit.osmocom.org/2760
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I042cc76258df7e4c6c90a73af3d0a6e75999b2b0
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Tom Tsou <tom at tsou.cc>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list