osmo-gsm-tester[master]: resource error logging that is easier to understand

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun May 28 22:16:02 UTC 2017


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/2705/2/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:

Line 468:                                  self.count(kind) + 1,
> You didn't move this to the line above
yes, because there is a benefit in the diff's clarity by just adding a line in the middle, and each arg is on its own line -> easier to read, especially with that 'if' following below.


-- 
To view, visit https://gerrit.osmocom.org/2705
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6887bbe5fe74a73f0e344cd4078dd7ed989cc15
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list