This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 2:
(7 comments)
thanks for the excellent review!
https://gerrit.osmocom.org/#/c/2719/2/example/defaults.conf
File example/defaults.conf:
Line 14: short_name: osmo-gsm-tester-msc
> Shall both msc and bsc have a short_name and long_name?
I'm not sure at all :P -- I haven't configured osmo-bsc at all before, and am completely oblivious about which parts should go to the BSC and which to the MSC config... so far I'm just duplicating, hopefully to shrink up later.
https://gerrit.osmocom.org/#/c/2719/2/src/osmo_gsm_tester/osmo_bsc.py
File src/osmo_gsm_tester/osmo_bsc.py:
Line 25: class OsmoBsc(log.Origin):
> Now that we have the BTS talking with the same API to both the OsmoNitb and
yes. Technically, the same goes for the BTS code. So far I went with 'Polymorphism is highly overrated' and kept each implementation on its own. I am not a fan of duplicating code at all, so unifying some bits is probably a good idea. My excuse so far is I wanted to see what it ends up to be and then identify the common bits.
Line 35: self.eth_iface = eth_iface
> So the conclusion finally was to leave it as eth_iface? I thought we conclu
wait a minute, I changed it to ip_address!?? I'll fix, thx
https://gerrit.osmocom.org/#/c/2719/2/src/osmo_gsm_tester/osmo_hlr.py
File src/osmo_gsm_tester/osmo_hlr.py:
Line 84: self.dbg(conf=values)
> You may want to add: 'HLR CONFIG:\n' +
whoa, I thought I had, thx
Line 107: self.run_local(name, ('/bin/sh', '-c', 'sqlite3 %r < %r' % (self.db_file, sql_file)))
> You need to add sqlite3 to the dependecies in the README file.
thx
https://gerrit.osmocom.org/#/c/2719/2/src/osmo_gsm_tester/osmo_msc.py
File src/osmo_gsm_tester/osmo_msc.py:
Line 115: var = 'subscriber-list-active-v1'
> This line can be removed
the mixup of copying code before applying patches :)
https://gerrit.osmocom.org/#/c/2719/2/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl
File src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl:
Line 8
> There's no specific hlr section?
now that I think of it, this should contain the ctrl and vty bind addresses! But nope, nothing to be configured for the HLR yet.
--
To view, visit https://gerrit.osmocom.org/2719
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5842e8f1cba8e8e6bedfc08540efcafe207159cb
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes