[MERGED] osmocom-bb[master]: mobile/gsm48_rr.c: fix BA range exceed check

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu May 25 00:04:37 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: mobile/gsm48_rr.c: fix BA range exceed check
......................................................................


mobile/gsm48_rr.c: fix BA range exceed check

Change-Id: Ic2ebe9faeeda7ce812527962d209e6049f2dfc75
---
M src/host/layer23/src/mobile/gsm48_rr.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c
index 9b3f0f9..b821457 100644
--- a/src/host/layer23/src/mobile/gsm48_rr.c
+++ b/src/host/layer23/src/mobile/gsm48_rr.c
@@ -146,11 +146,13 @@
 		*ranges = 0;
 		return -EINVAL;
 	}
-	if (max_ranges > n)
+
+	if (n > max_ranges) {
 		LOGP(DRR, LOGL_NOTICE, "BA range %d exceed the maximum number "
 			"of ranges supported by this mobile (%d).\n",
 			n, max_ranges);
 		n = max_ranges;
+	}
 
 	/* decode ranges */
 	for (i = 0; i < n; i++) {

-- 
To view, visit https://gerrit.osmocom.org/2663
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2ebe9faeeda7ce812527962d209e6049f2dfc75
Gerrit-PatchSet: 3
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list