This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has submitted this change and it was merged. Change subject: fix '/include/openbsc ' to have no trailing space ...................................................................... fix '/include/openbsc ' to have no trailing space The newline and $NULL manage to append a trailing space to the 'openbsc' dir. This was broken in commit 7b6673fa06dada3ec4586b1c0d735e9df4177a48 "Consistenly format variables in */Makefile.am files" by Change-Id Ifa21513c007072314097b7bec188579972dc1694 Add a comment to prevent this in the future. Reported-by: Andreas Mueller <andreas.mueller at criticallabs.org> Change-Id: I218027459e3b2aaa817d91eb3f69d9c0b10dcd4e --- M openbsc/include/openbsc/Makefile.am 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/openbsc/include/openbsc/Makefile.am b/openbsc/include/openbsc/Makefile.am index 7ddf323..eb09e18 100644 --- a/openbsc/include/openbsc/Makefile.am +++ b/openbsc/include/openbsc/Makefile.am @@ -93,6 +93,6 @@ meas_rep.h \ $(NULL) -openbscdir = \ - $(includedir)/openbsc \ - $(NULL) +# DO NOT add a newline and '$(NULL)' to this line. That would add a trailing +# space to the directory installed: $prefix/include/'openbsc ' +openbscdir = $(includedir)/openbsc -- To view, visit https://gerrit.osmocom.org/2649 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I218027459e3b2aaa817d91eb3f69d9c0b10dcd4e Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>