osmo-gsm-tester[report]: Handle termination signals to exit gracefully and prevent re...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri May 19 11:57:51 UTC 2017


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/2670/2/src/osmo-gsm-tester.py
File src/osmo-gsm-tester.py:

Line 200:         except Exception:
this is made stricter to not catch SystemExit? because we don't want to delay by writing to a log file? (maybe place a comment)


https://gerrit.osmocom.org/#/c/2670/2/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:

Line 269:             self.stop_processes()
this stops child processes, but how is the resource cleaning ensured? via atexit, right? (could be mentioned in the comment)


-- 
To view, visit https://gerrit.osmocom.org/2670
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I039e4d1908a04bf606b101ddc6a186ba67e6178e
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: report
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list