This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgHello Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2658 to look at the new patch set (#3). sap_interface.c: drop meaningless condition If sap_state is equal to SAP_NOT_CONNECTED, it cannot be equal to another value at the same time. So the second part of condition doesn't make sense. Change-Id: I3038fc15745dc4be796d894002524e6b2dd5c90e --- M src/host/layer23/src/common/sap_interface.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/58/2658/3 diff --git a/src/host/layer23/src/common/sap_interface.c b/src/host/layer23/src/common/sap_interface.c index 22f9550..fd19659 100644 --- a/src/host/layer23/src/common/sap_interface.c +++ b/src/host/layer23/src/common/sap_interface.c @@ -151,7 +151,7 @@ static int osmosap_send(struct osmocom_ms *ms, struct msgb *msg) { - if(ms->sap_entity.sap_state == SAP_NOT_CONNECTED && !ms->sap_entity.sap_state == SAP_CONNECTION_UNDER_NEGOTIATION) + if(ms->sap_entity.sap_state == SAP_NOT_CONNECTED) sap_connect(ms); if (ms->sap_wq.bfd.fd <= 0) -- To view, visit https://gerrit.osmocom.org/2658 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3038fc15745dc4be796d894002524e6b2dd5c90e Gerrit-PatchSet: 3 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>