[MERGED] libosmocore[master]: src/select.c: Don't #include <sys/select.h> if it doesn't exist

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed May 17 17:48:14 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: src/select.c: Don't #include <sys/select.h> if it doesn't exist
......................................................................


src/select.c: Don't #include <sys/select.h> if it doesn't exist

We have to #include <sys/select.h> inside the block protected by
HAVE_SYS_SELECT_H, otherwise it will fail on (embedded) builds where
that file doesn't exist, such as the arm-none-eabi target on Debian
stable and Ubuntu 16.04.

Change-Id: I82a2dcbc55b6ee0e914881c5e09b80506c5de4f2
---
M src/select.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/select.c b/src/select.c
index 8ed7f1b..afc8198 100644
--- a/src/select.c
+++ b/src/select.c
@@ -24,7 +24,6 @@
 #include <stdio.h>
 #include <string.h>
 #include <stdbool.h>
-#include <sys/select.h>
 
 #include <osmocom/core/select.h>
 #include <osmocom/core/linuxlist.h>
@@ -33,6 +32,7 @@
 #include "../config.h"
 
 #ifdef HAVE_SYS_SELECT_H
+#include <sys/select.h>
 
 /*! \addtogroup select
  *  @{

-- 
To view, visit https://gerrit.osmocom.org/2671
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I82a2dcbc55b6ee0e914881c5e09b80506c5de4f2
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list