This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/2640 sercomm: remove unrequired helper functions osmo_sercomm_{bind,get}_uart() are not really needed anymore, as sercomm_inst is public and thus the user can access the uart_id member directly. Change-Id: I6d57709c3764036046202f16a26c9eb87426c8d1 --- M include/osmocom/core/sercomm.h M src/sercomm.c 2 files changed, 0 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/40/2640/1 diff --git a/include/osmocom/core/sercomm.h b/include/osmocom/core/sercomm.h index 0583390..cc1a833 100644 --- a/include/osmocom/core/sercomm.h +++ b/include/osmocom/core/sercomm.h @@ -61,8 +61,6 @@ #ifndef HOST_BUILD #include <uart.h> /* helper functions for target */ -void osmo_sercomm_bind_uart(struct osmo_sercomm_inst *sercomm, int uart); -int osmo_sercomm_get_uart(struct osmo_sercomm_inst *sercomm); void osmo_sercomm_change_speed(struct osmo_sercomm_inst *sercomm, enum uart_baudrate bdrt); #endif diff --git a/src/sercomm.c b/src/sercomm.c index 75e7968..d33db91 100644 --- a/src/sercomm.c +++ b/src/sercomm.c @@ -73,19 +73,6 @@ RX_ST_ESCAPE, }; - -#ifndef HOST_BUILD -void osmo_sercomm_bind_uart(struct osmo_sercomm_inst *sercomm, int uart) -{ - sercomm->uart_id = uart; -} - -int osmo_sercomm_get_uart(struct osmo_sercomm_inst *sercomm) -{ - return sercomm->uart_id; -} -#endif - void osmo_sercomm_init(struct osmo_sercomm_inst *sercomm) { unsigned int i; -- To view, visit https://gerrit.osmocom.org/2640 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6d57709c3764036046202f16a26c9eb87426c8d1 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org>