[PATCH] libosmocore[master]: gsm_04_08: Add missing GSM cause value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Fri May 12 09:27:44 UTC 2017


Review at  https://gerrit.osmocom.org/2582

gsm_04_08: Add missing GSM cause value

Table 10.5.157 in 10.5.6.6 of 3GPP TS 04.08 is badly formatted. The first
value 0x19 "LLC or SNDCP failure" is in the same line as the heading and has
not been included in the struct_value so far.

Change-Id: I5bcc52f739ff0677011d024448afcc2a54869638
---
M include/osmocom/gsm/protocol/gsm_04_08_gprs.h
M src/gsm/gsm_04_08_gprs.c
2 files changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/2582/1

diff --git a/include/osmocom/gsm/protocol/gsm_04_08_gprs.h b/include/osmocom/gsm/protocol/gsm_04_08_gprs.h
index cda1e48..52894e4 100644
--- a/include/osmocom/gsm/protocol/gsm_04_08_gprs.h
+++ b/include/osmocom/gsm/protocol/gsm_04_08_gprs.h
@@ -206,6 +206,7 @@
 
 /* Chapter 10.4.6.6 / Table 10.5.157 */
 enum gsm48_gsm_cause {
+	GSM_CAUSE_LLC_SNDCP_FAIL	= 0x19,
 	GSM_CAUSE_INSUFF_RSRC		= 0x1a,
 	GSM_CAUSE_MISSING_APN		= 0x1b,
 	GSM_CAUSE_UNKNOWN_PDP		= 0x1c,
diff --git a/src/gsm/gsm_04_08_gprs.c b/src/gsm/gsm_04_08_gprs.c
index 6f0baba..ec1e1fb 100644
--- a/src/gsm/gsm_04_08_gprs.c
+++ b/src/gsm/gsm_04_08_gprs.c
@@ -75,6 +75,7 @@
 
 /* 10.5.6.6 SM Cause / Table 10.5.157 */
 const struct value_string gsm48_gsm_cause_names_[] = {
+	{ GSM_CAUSE_LLC_SNDCP_FAIL, "LLC or SNDCP failure" },
 	{ GSM_CAUSE_INSUFF_RSRC, "Insufficient resources" },
 	{ GSM_CAUSE_MISSING_APN, "Missing or unknown APN" },
 	{ GSM_CAUSE_UNKNOWN_PDP, "Unknown PDP address or PDP type" },

-- 
To view, visit https://gerrit.osmocom.org/2582
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bcc52f739ff0677011d024448afcc2a54869638
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: daniel <dwillmann at sysmocom.de>



More information about the gerrit-log mailing list