[MERGED] osmo-bts[master]: osmo-bts-trx/l1_if.c: cosmetic: drop double check

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue May 9 22:18:20 UTC 2017


Vadim Yanitskiy has submitted this change and it was merged.

Change subject: osmo-bts-trx/l1_if.c: cosmetic: drop double check
......................................................................


osmo-bts-trx/l1_if.c: cosmetic: drop double check

Change-Id: I25a8f85ee65e1c0dd54049ffacc039702ca36c8f
---
M src/osmo-bts-trx/l1_if.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c
index d0c8afd..f9ba5fa 100644
--- a/src/osmo-bts-trx/l1_if.c
+++ b/src/osmo-bts-trx/l1_if.c
@@ -182,16 +182,16 @@
 	 && l1h->config.bsic_valid
 	 && l1h->config.arfcn_valid) {
 	 	/* before power on */
-		if (l1h->config.arfcn_valid && !l1h->config.arfcn_sent) {
+		if (!l1h->config.arfcn_sent) {
 			trx_if_cmd_rxtune(l1h, l1h->config.arfcn);
 			trx_if_cmd_txtune(l1h, l1h->config.arfcn);
 			l1h->config.arfcn_sent = 1;
 		}
-		if (l1h->config.tsc_valid && !l1h->config.tsc_sent) {
+		if (!l1h->config.tsc_sent) {
 			trx_if_cmd_settsc(l1h, l1h->config.tsc);
 			l1h->config.tsc_sent = 1;
 		}
-		if (l1h->config.bsic_valid && !l1h->config.bsic_sent) {
+		if (!l1h->config.bsic_sent) {
 			trx_if_cmd_setbsic(l1h, l1h->config.bsic);
 			l1h->config.bsic_sent = 1;
 		}

-- 
To view, visit https://gerrit.osmocom.org/2474
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I25a8f85ee65e1c0dd54049ffacc039702ca36c8f
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>



More information about the gerrit-log mailing list