This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/2473/1/src/gb/gprs_ns.c File src/gb/gprs_ns.c: Line 300: OSMO_VALUE_STRING(NS_PDUT_UNITDATA), I really don;'t like the aut-generated value strings in a lot of cases. The user expects to se a "NS-UNITDATA", as this is how it is called in wireshark and in the spec. We will now print an "NS_PDUT_UNITDATA" which is longer, non-standard and likely causes the question whether that's equal to NS-UNITDATA or not. So pleae go the extra mile and write the strings names like in the spec. https://gerrit.osmocom.org/#/c/2473/1/src/gb/libosmogb.map File src/gb/libosmogb.map: Line 41: ns_pdu_strings; all the symbols below this line are prefixed with gprs_ns, just your new symbol is not. I think new code should always stay consistent to the existing code. -- To view, visit https://gerrit.osmocom.org/2473 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ea3a45f35d68619d4cfa9735ef77abd9f9f0d58 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes