libosmocore[master]: gsm0808: Add utils for AoIP Transport Layer Address

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Mar 30 17:29:15 UTC 2017


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/2176/2/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

Line 72: struct sockaddr_storage *gsm0808_dec_aoip_trasp_addr(const void *ctx,
in genera we try to avoid dynamic allcoations whenever it is not needed, So I guess a more natural way to do this is to pass a caller-allocated 'struct sockaddr_storage *' as argument into the function.  This way, the caller can pass the address-of a member structure of some internal state into the decoder.


-- 
To view, visit https://gerrit.osmocom.org/2176
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57933b0a06a3f54ec2a41e6ecb6ced9fbbc89332
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list