libosmocore[master]: gsm0808: Add utils for Speech Codec List and Speech Codec

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Mar 30 17:27:56 UTC 2017


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/2177/2/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

Line 151: struct msgb *gsm0808_enc_speech_codec(struct gsm0808_speech_codec *sc)
I think I don't really understand the idea behind those functions.  When we encode an entire message (like "ASSIGNMENT REQUEST", it makes sense to allocate a new msgb, and then send that msgb via the A interface.

However, allocating msgb's for individual information elements?  How do I use this API?  Normally I would expect that I create some msgb for a given message type, and then add information elements to it.   But this code seems to assume that every IE is its own msgb?


-- 
To view, visit https://gerrit.osmocom.org/2177
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e1e2edf47adaa45b22d4b0bcae3640dba7ca200
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list