[MERGED] libosmo-abis[master]: Fix RTP jitter buffer that never stop to increase.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 29 13:40:22 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: Fix RTP jitter buffer that never stop to increase.
......................................................................


Fix RTP jitter buffer that never stop to increase.

Duration passed to osmo_rtp_send_frame_ext function is based
on the last frame and the current one. Duration must then be
added to the timestamp before being transmitted.

Change-Id: I0593d6530c097cca34125a0ae2dd1b019b4dd80d
---
M src/trau/osmo_ortp.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/trau/osmo_ortp.c b/src/trau/osmo_ortp.c
index 141065e..4e9df56 100644
--- a/src/trau/osmo_ortp.c
+++ b/src/trau/osmo_ortp.c
@@ -467,9 +467,9 @@
 		return -ENOMEM;
 
 	rtp_set_markbit(mblk, marker);
+	rs->tx_timestamp += duration;
 	rc = rtp_session_sendm_with_ts(rs->sess, mblk,
 				       rs->tx_timestamp);
-	rs->tx_timestamp += duration;
 	if (rc < 0) {
 		/* no need to free() the mblk, as rtp_session_rtp_send()
 		 * unconditionally free()s the mblk even in case of

-- 
To view, visit https://gerrit.osmocom.org/1982
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0593d6530c097cca34125a0ae2dd1b019b4dd80d
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: jfdionne <jf.dionne at nutaq.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: jfdionne <jf.dionne at nutaq.com>



More information about the gerrit-log mailing list