This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/2161/1/openbsc/include/openbsc/gsm_data_shared.h File openbsc/include/openbsc/gsm_data_shared.h: Line 502: BTS_UNKNOWN, > It looks to me like this is semantically the same as enum gsm_bts_type just enum gsm_bts_type should basically differentiate bdtween BS11/nanobts/rbs2000/nokia/osmo (without 'sysmo') and then inside 'osmo' we have the sub-variants that are now introduced in 'gsm_bts_model_variant'. It might be best to renaem GSM_BTS_TYPE_OSMO_SYSMO to GSM_BTS_OSMOBTS and to rename gsm_bts_model_variant into osmobts_variant or something like that. -- To view, visit https://gerrit.osmocom.org/2161 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6710d53115f34634a7b70969cc05fd5c72ff8ab2 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes