osmo-trx[master]: Move Transceiver::detectBurst() to sigProcLib to make it reu...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Tom Tsou gerrit-no-reply at lists.osmocom.org
Fri Mar 24 00:17:22 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/2148/1/Transceiver52M/sigProcLib.cpp
File Transceiver52M/sigProcLib.cpp:

PS1, Line 1930: max_toa_nb
> Yes, makes sense. It may make higher level code a bit more complex with an 
Perhaps if or when we have non-static SigProc objects, we can remove passing in the same TSC, threshold, and TOA values on every detect() call.

In the meantime, we should at least try to minimize long argument lists with redundant values.


-- 
To view, visit https://gerrit.osmocom.org/2148
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cbe8e6e4f39dde02c945e6c9086c040e276845c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Tom Tsou <tom at tsou.cc>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list