osmo-trx[master]: buildenv: Split up SSE3 and SSE4.1 code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Mar 23 09:36:34 UTC 2017


Patch Set 1: Code-Review+1

> could you
 > take a brief look and decide which way to go with the 'attribute'
 > style -- are they no longer needed now, or should we rewrite this
 > patch to use those instead?

this is exactly what has happened. The implementation first used those attributes and now switched to separate files. Guess you have missed the history here.  Both dexter and I agree that the separate files makes us more comfortable in being certain any version of the compiler will never use the wrong optimziation in the wrong function.

-- 
To view, visit https://gerrit.osmocom.org/2134
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I846e190e92f1258cd412d1b2d79b539e204e04b3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list