[MERGED] osmo-sip-connector[master]: mncc: Enable in-band signalling for early media

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Thu Mar 23 09:01:14 UTC 2017


Holger Freyther has submitted this change and it was merged.

Change subject: mncc: Enable in-band signalling for early media
......................................................................


mncc: Enable in-band signalling for early media

Besides sending the alerting request we should inform the
MS that there is in-band information now. We do not seem
to export these flags in protocol/gsm_04_08.h so hardcode
them for now (until I come up with good names for them).

Related: OS#1784

Change-Id: I80b1e1f4ca045bd63536476702a5812f27d9b36d
---
M src/mncc.c
1 file changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Holger Freyther: Looks good to me, approved



diff --git a/src/mncc.c b/src/mncc.c
index 843c7e7..5e2a3a1 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -194,12 +194,20 @@
 
 static void mncc_call_leg_ring(struct call_leg *_leg)
 {
+	struct gsm_mncc out_mncc = { 0, };
 	struct mncc_call_leg *leg;
 
 	OSMO_ASSERT(_leg->type == CALL_TYPE_MNCC);
 	leg = (struct mncc_call_leg *) _leg;
 
-	mncc_send(leg->conn, MNCC_ALERT_REQ, leg->callref);
+	mncc_fill_header(&out_mncc, MNCC_ALERT_REQ, leg->callref);
+	/* GSM 04.08 10.5.4.21 */
+	out_mncc.fields |= MNCC_F_PROGRESS;
+	out_mncc.progress.coding = 3; /* Standard defined for the GSMßPLMNS */
+	out_mncc.progress.location = 1; /* Private network serving the local user */
+	out_mncc.progress.descr = 8; /* In-band information or appropriate pattern now available */
+
+	mncc_write(leg->conn, &out_mncc, leg->callref);
 }
 
 static void mncc_call_leg_release(struct call_leg *_leg)

-- 
To view, visit https://gerrit.osmocom.org/2029
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I80b1e1f4ca045bd63536476702a5812f27d9b36d
Gerrit-PatchSet: 3
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list