[PATCH] osmo-trx[master]: Resampler: Fix initialization return checking

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Tom Tsou gerrit-no-reply at lists.osmocom.org
Wed Mar 22 20:54:12 UTC 2017


Review at  https://gerrit.osmocom.org/2159

Resampler: Fix initialization return checking

Greater-than comparison was used on boolean type.

Change-Id: Ia3b71b3a06b34a6fd781bf197ecf9d5cc1711d13
---
M Transceiver52M/Resampler.cpp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/59/2159/1

diff --git a/Transceiver52M/Resampler.cpp b/Transceiver52M/Resampler.cpp
index 8a73b79..72b11a9 100644
--- a/Transceiver52M/Resampler.cpp
+++ b/Transceiver52M/Resampler.cpp
@@ -191,7 +191,7 @@
 bool Resampler::init(float bw)
 {
 	/* Filterbank filter internals */
-	if (initFilters(bw) < 0)
+	if (!initFilters(bw))
 		return false;
 
 	/* Precompute filterbank paths */

-- 
To view, visit https://gerrit.osmocom.org/2159
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3b71b3a06b34a6fd781bf197ecf9d5cc1711d13
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Tom Tsou <tom at tsou.cc>



More information about the gerrit-log mailing list