osmo-trx[master]: osmo-trx: Separate command line switch to enable EDGE filler.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Alexander Chemeris gerrit-no-reply at lists.osmocom.org
Wed Mar 22 17:45:04 UTC 2017


Patch Set 2:

> Maybe we can replace both -r and -E with new --filler which will
 > figure out appropriate filler based on other options by checking if
 > edge is enabled or not?

That's exactly what this patch is moving away from. Right now -r option has different behavior based on whether -e is specified or not, which means that I can't generate random GMSK burst if I run in EDGE mode, which is very inconvenient.

What we can do is to make this a control interface command rather than a command line parameter. It'll make it harder to use, but more clean from the code perspective.

-- 
To view, visit https://gerrit.osmocom.org/2143
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8808bbe3f06740ef3fec1d1865ecb57fbcfabab
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Tom Tsou <tom at tsou.cc>
Gerrit-HasComments: No



More information about the gerrit-log mailing list