This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Alexander Chemeris gerrit-no-reply at lists.osmocom.orgPatch Set 1: (1 comment) > (1 comment) https://gerrit.osmocom.org/#/c/2136/1/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: Line 609: float toa, max = -1.0, avg = 0.0; > Is there good reason not to move it? I prefer the moved declaration. I follow the rule "declare variable in the least possible namespace". Helps a lot with code modularity and clarity. That's different from C where everything must be declared in the beginning of a function. -- To view, visit https://gerrit.osmocom.org/2136 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bf97f2dc03fea9bebcf43198dfb05f6e4694e9c Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: Alexander Chemeris <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Tom Tsou <tom at tsou.cc> Gerrit-HasComments: Yes