osmo-trx[master]: osmo-trx: Separate command line switch to enable EDGE filler.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Mar 21 09:58:57 UTC 2017


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/2143/2/Transceiver52M/osmo-trx.cpp
File Transceiver52M/osmo-trx.cpp:

Line 419: 		case 'E':
So user can still specify ... -E 123 -r 321 ... without enabling EDGE and it'll work (provided options are parsed from left to right) because "-r" will shadow "-E", but ... -r 123 -E 321 ... will fail.

I think it's better to make "-E" and "-r" mutually exclusive - unless there's use-case when we actually need both.


-- 
To view, visit https://gerrit.osmocom.org/2143
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8808bbe3f06740ef3fec1d1865ecb57fbcfabab
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Tom Tsou <tom at tsou.cc>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list