This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (3 comments) in OS#1869 there is mention of the 'attribute' based per-function cpu features, but I can't see them in this patch. I must apologize because I assumed you were aware of this way to solve, since Holger had already posted it a long time ago somewhere. I should have brought your attention to it more urgently. With those attributes it may not be necessary to separate the files at all ... could you take a brief look and decide which way to go with the 'attribute' style -- are they no longer needed now, or should we rewrite this patch to use those instead? https://gerrit.osmocom.org/#/c/2134/1/Transceiver52M/x86/Makefile.am File Transceiver52M/x86/Makefile.am: Line 33: whitespace https://gerrit.osmocom.org/#/c/2134/1/Transceiver52M/x86/convert.c File Transceiver52M/x86/convert.c: Line 36: void (*convert_scale_ps_si16) (short *, const float *, float, int); this doesn't change anything, does it?? drop this chunk. https://gerrit.osmocom.org/#/c/2134/1/utils/convolvetest/Makefile File utils/convolvetest/Makefile: Line 19: (we usually avoid empty lines at eof) -- To view, visit https://gerrit.osmocom.org/2134 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I846e190e92f1258cd412d1b2d79b539e204e04b3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes