This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/2071/3/src/encoding.cpp File src/encoding.cpp: Line 627: "octets is not multiple of 8 bits, exiting."); as we have already two instances where the same string is used first for a LOGP and then for a pcu_tx_txt_ind, it might make sense to have a convenience wrapper for both, i.e. logging + txt indication? https://gerrit.osmocom.org/#/c/2071/3/src/pcu_l1_if.cpp File src/pcu_l1_if.cpp: Line 97: rep = talloc_vasprintf(tall_pcu_ctx, fmt, ap); you're checking for msgb_alloc == NULL above, but not for the allocation failure that might be in talloc_vasprintf. -- To view, visit https://gerrit.osmocom.org/2071 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4ea5b3f7409df2fb030681ad468df6b711790a7 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-HasComments: Yes