openbsc[master]: Handle PCU version received viam OML alert

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Mar 16 09:49:17 UTC 2017


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/2085/1/openbsc/src/libbsc/abis_nm.c
File openbsc/src/libbsc/abis_nm.c:

PS1, Line 296: p
this kind of code structure won't scale and is not well prepared to handling other types of event reports.  Please add some kind of a dispatcher table, where one can easily add parser/handlers for other types.


Line 299: 			if (c == OSMO_EVT_PCU_VERS) {
please introduce one handler function for NM_PCAUSE_T_MANUF (which should be part of the "bts model" and call it there.  And in that bts-specific handler function (for sysmobts at this time), use a switch statement on the 'c'


-- 
To view, visit https://gerrit.osmocom.org/2085
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c88663d4e2887a4038b4c3f1387128295b8934e
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list