[PATCH] openbsc[master]: abis_rsl: fix off-by-one length check when parsing ericson t...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Mar 14 14:41:41 UTC 2017


Review at  https://gerrit.osmocom.org/2068

abis_rsl: fix off-by-one length check when parsing ericson tlli field

Change-Id: I658f6d82a67944345ddda5534fa996dca9e990ab
---
M openbsc/src/libbsc/abis_rsl.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/68/2068/1

diff --git a/openbsc/src/libbsc/abis_rsl.c b/openbsc/src/libbsc/abis_rsl.c
index ba52c09..e494229 100644
--- a/openbsc/src/libbsc/abis_rsl.c
+++ b/openbsc/src/libbsc/abis_rsl.c
@@ -2038,7 +2038,7 @@
 		/* FIXME: Replace the messy message parsing below
 		 * with proper TV parser */
 		LOGP(DRSL, LOGL_INFO, "IMM.ass sent\n");
-		if(msg->len < 8)
+		if(msg->len < 9)
 			LOGP(DRSL, LOGL_ERROR, "short IMM.ass sent message!\n");
 		else if(msg->data[4] != 0xf1)
 			LOGP(DRSL, LOGL_ERROR, "unsupported IMM.ass message format! (please fix)\n");

-- 
To view, visit https://gerrit.osmocom.org/2068
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I658f6d82a67944345ddda5534fa996dca9e990ab
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>



More information about the gerrit-log mailing list