libosmocore[master]: build: cosmetic: coding: break a CPPFLAGS line

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Mar 14 00:19:21 UTC 2017


Patch Set 1:

> I thought the general rule were to break lines at 80 symbols. Why
 > special exception for makefiles? I think it harms readability
 > instead of improving it.

I created this patch because you asked for it. It makes the other patch more readable, as clearly stated in the commit log.

Obviously, in a makefile, we often add single files or flags to these lists. The diffs become far more readable if each file is on its own line.

Please let's not discuss things just for the sake of discussing.

-- 
To view, visit https://gerrit.osmocom.org/2043
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174086a988b51b6e80f3661609069b69a3d41cc7
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: No



More information about the gerrit-log mailing list