libosmocore[master]: vty: fix "logging level ... everything" option

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Mar 13 14:02:31 UTC 2017


Patch Set 10:

> 1) it's confusing as hell

I don't think it's confusing at all. We have a keyword for addressing all items, and using the keyword consistently for both subsystem as well as log level. Surely everyone is familiar with the concept of argument ordering.

 > why "debug" would not suffice?

I explained so in my comment, please read above and look at the code. I assumed that this is the main reason why you submitted this patch in the first place: that the 'everything' skips all logging filters and prints logs right away.

Also setting the 'all all' flag does not interfere with the more detailed logging levels per subsystem: I can set e.g. RSL to NOTICE and MM to ERROR, then for a short time I can set 'all all' to see really everything, and a minute later I can switch off the 'all all' to return back to RSL=NOTICE and MM=ERROR without having to redefine the logging landscape.

Why else would you bother with this patch? :)

-- 
To view, visit https://gerrit.osmocom.org/1582
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib51987fb2f64a70fca130f3799dc8fd71cc7085c
Gerrit-PatchSet: 10
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list