This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2031/2/openbsc/src/libcommon/gsm_data_shared.c
File openbsc/src/libcommon/gsm_data_shared.c:
Line 54: const struct value_string gsm_chreq_descs[7] = {
> I'm happy to do away with the explicit count if it's no longer needed. I a
maybe one needs to declare them 'extern' in the header file to avoid such warnings? just guessing, that's what we do everywhere else. Maybe it's related to the PCU being C++.
Anyway, I guess that would be a change not related to this patch.
--
To view, visit https://gerrit.osmocom.org/2031
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23d3be5610a5a46098d2b12feed4245828599aae
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: Yes