openbsc[master]: gsm_data_shared: add value strings for gsm_chreq

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Mar 13 13:03:59 UTC 2017


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/2031/2/openbsc/src/libcommon/gsm_data_shared.c
File openbsc/src/libcommon/gsm_data_shared.c:

Line 54: const struct value_string gsm_chreq_descs[7] = {
> 7 is correct, maybe forgot to count the termination entry?
I'm happy to do away with the explicit count if it's no longer needed.  I am quite sure there were times/situations where at least some versions of gcc didn't like forward-declaraitons of undefined array sizes in header files.


-- 
To view, visit https://gerrit.osmocom.org/2031
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23d3be5610a5a46098d2b12feed4245828599aae
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list