This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/1991/1/src/osmo-bts-sysmo/misc/sysmobts_mgr_temp.c File src/osmo-bts-sysmo/misc/sysmobts_mgr_temp.c: Line 200: rep = ctrl_cmd_create(tall_mgr_ctx, CTRL_TYPE_SET); now the code assumes that rep->value is NULL after ctrl_cmd_create(), which makes a lot of sense, but hopefully we will never introduce a default value in future. Maybe OSMO_ASSERT(!rep->value) here? -- To view, visit https://gerrit.osmocom.org/1991 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19e1ce5fae6f936c9ed93f9a6317b57d28d7311 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes