osmo-gsm-manuals[master]: osmo-sgsn: fix arrow tips in flow diagrams

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Mar 13 02:31:34 UTC 2017


Patch Set 2: Code-Review-2

(4 comments)

https://gerrit.osmocom.org/#/c/2022/2/OsmoSGSN/chapters/gsup.adoc
File OsmoSGSN/chapters/gsup.adoc:

Line 69:   Peer <= SGSN [label="SEND AUTHENTICATION INFO RESPONSE (Tuples)"];
No, the SGSN is the one requesting auth info from the HLR, and then the HLR responds with tuples.


Line 81:   Peer <= SGSN [label="SEND AUTHENTICATION INFO ERROR (Cause)"];
nope


Line 97:   SGSN <= Peer [label="AUTHENTICATION FAILURE REPORT (IMSI)"];
again, nope. The HLR gets informed of auth failure in case the subscriber failed to authorize


Line 118:   SGSN <= Peer [label="UPDATE LOCATION REQUEST (IMSI)"];
I think you're mistaking "peer" for the MS. The peer for GSUP is the HLR, and the SGSN is the "client" for retrieving data from the HLR database. All of these arrows were correct.


-- 
To view, visit https://gerrit.osmocom.org/2022
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7faa0c97ee3705a64289a47bc63f311d05f988b3
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list