This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/2018/1/openbsc/src/ipaccess/ipaccess-config.c File openbsc/src/ipaccess/ipaccess-config.c: Line 629: load->file_id_len = strlen((char*)load->file_id) + 1; > Why +1? The \0 added by osmo_strlcpy() is included in size parameter for it I'm a bit confused, what are you saying? The sizeof() passed to osmo_strlcpy() has no +1, obviously. load->file_id_len is an indicator to the rest of the program, I'm not going to change the meaning of this value, which was, apparently, and still is "strlen() + 1". If you'd like me to use osmo_strlcpy()'s return value instead of strlen(): actually osmo_strlcpy returns the length of the input string, not the length copied; neither does that include the \0. I tried to add an osmo_str*cpy that has an actually useful return value once, but discussion around that dragged on too far to be worth it. -- To view, visit https://gerrit.osmocom.org/2018 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e34a1348a290d3f58dd830d08da65b94b3270db Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes