libosmo-abis[master]: lapd: Improve log output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Mar 13 01:58:57 UTC 2017


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/2011/1//COMMIT_MSG
Commit Message:

Line 7: lapd: Improve log output
"Improve" is too general :) "log pointer addresses"


https://gerrit.osmocom.org/#/c/2011/1/src/input/lapd.c
File src/input/lapd.c:

Line 234: 	     sapi, teip->tei, &sap->dl, sap);
this is actually NOTICE output, not DEBUG output as mentioned in the commit log.

Aside: when writing tests and checking the produced log output, pointer addresses are very impractical because they change for every test run. I assume there isn't a better way, an id or name, to track the objects?

And do we really need to track the pointers in the log output in production code? is this just to resolve a bug and then it just amounts to bloat? In libosmocore's fsm.c, a similar situation is solved by the fsm_log_addr flag, see https://git.osmocom.org/libosmocore/tree/src/fsm.c:91

We can add this, but please confirm that it really makes sense.


Line 711: 
please drop this whitespace change


-- 
To view, visit https://gerrit.osmocom.org/2011
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b961d5e36967cfd953551b24696849541257a1c
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list