This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 4: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/2007/4/src/bts.cpp File src/bts.cpp: Line 532: OSMO_ASSERT(rfn < 26 * 51 * 2048); we have a #define for this in libosmocore. I mentioned this in the original patch introducing rfn_to_fn() alrady, and now again... Also, he reduced/relative frame number is generally much smaller than the real frame number. It would e really nonsensical to try to expand a non-reduced fn to a real fn. bu then, it is an assert, so let's keep it. -- To view, visit https://gerrit.osmocom.org/2007 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6d895a97aa35414f245ea4406c6e78f1b4fb5b8 Gerrit-PatchSet: 4 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-HasComments: Yes