[PATCH] osmo-pcu[master]: BTS: fix overloading ambiguity

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Mon Mar 6 15:54:39 UTC 2017


Review at  https://gerrit.osmocom.org/1981

BTS: fix overloading ambiguity

cast the result of rfn - m_cur_rfn to long int explicitly to avoid
the overloading ambiguity.

Change-Id: I146dd82d9a18b1ad28749f960068d3b4e4cbfd9d
---
M src/bts.cpp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/81/1981/1

diff --git a/src/bts.cpp b/src/bts.cpp
index 548d000..75beaec 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -550,7 +550,7 @@
 	 * number exceeds a certain limit, we need to assume that the incoming
 	 * rach request belongs to a the previous rfn period. To correct this,
 	 * we roll back the rounded frame number by one RFN_MODULUS */
-	if (abs(rfn - m_cur_rfn) > RFN_THRESHOLD) {
+	if (abs((long int)(rfn - m_cur_rfn)) > RFN_THRESHOLD) {
 		LOGP(DRLCMAC, LOGL_DEBUG,
 		     "Race condition between rfn (%u) and m_cur_fn (%u) detected: rfn belongs to the previos modulus %u cycle, wrappng...\n",
 		     rfn, m_cur_fn, RFN_MODULUS);

-- 
To view, visit https://gerrit.osmocom.org/1981
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I146dd82d9a18b1ad28749f960068d3b4e4cbfd9d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>



More information about the gerrit-log mailing list