This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 3:
but in my view your reason to want that is either not sound or not clear.
Two lanes of discussion:
1. Allow terminating a value_string[] with { SOME_CONSTANT, NULL }?
2. How to design termination detection in the script:
If 1 is answered with 'no', it's easy, keep it as it is.
If 1 is answered with 'yes', I'll agree to change the script.
So let's resolve 1 first.
My vote for 1 (independently of 2) is: no, let's have literally the same termination of value_string[]s everywhere for code readability.
And I agree it would be good to get someone else's opinion to help us resolve it and stop reiterating the same points ;)
--
To view, visit https://gerrit.osmocom.org/1940
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bc93ab4781487e7685cfb63091a489cd126b1a8
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No