This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (2 comments) drop the occurRed change, maybe tweak the commit log, otherwise good. https://gerrit.osmocom.org/#/c/1968/1//COMMIT_MSG Commit Message: Line 7: spell checking A general welcome to Osmocom code review: would be good to clearly state what the patch does in imperative form, like "fix spelling", as well as in what kinds of strings -- "in logging, vty doc, API doc" -- and also in which code secions "in ctrl, gb, auth, lapd, vty". I hope that fits on the short summary line? Otherwise abbreviate with "in various <foo>" and give details in the rest of the commit log. https://gerrit.osmocom.org/#/c/1968/1/src/ctrl/control_if.c File src/ctrl/control_if.c: Line 272: cmd->reply = "An error has occurred."; 'occured' is actually correct spelling -- To view, visit https://gerrit.osmocom.org/1968 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac211b5cd8504da36b699777b95a2448dd7c3e70 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Thorsten Alteholz <osmocom at alteholz.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes