This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 3:
We could define an OSMO_VALUE_STRING_END (as {0, NULL}) and change this script to srictly require all arrays to end with literally OSMO_VALUE_STRING_END, without alternative ... but I prefer to expect what the code currently uses, avoiding to edit all arrays. I would agree to add an OSMO_VALUE_STRING_END to the script if we want to introduce it, but until then { 0, NULL } is what everyone should use. The point is that we can and should be strict on how to terminate value_string[]s, no need to be general about it (i.e. not beyond the variants we find in today's code).
--
To view, visit https://gerrit.osmocom.org/1940
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bc93ab4781487e7685cfb63091a489cd126b1a8
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No