openbsc[master]: sgsn: fix problem with leading-zero-IMSIs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 1 16:38:59 UTC 2017


Patch Set 2: -Code-Review

(1 comment)

https://gerrit.osmocom.org/#/c/1938/2/openbsc/src/gprs/sgsn_vty.c
File openbsc/src/gprs/sgsn_vty.c:

Line 595: 	if (strlen(argv[1]) > 15) {
please avoid magic numbers.  We almost always have #defines for such general GSM constants in libosmocore, such as GSM23003_IMSI_MAX_DIGITS in this case.


-- 
To view, visit https://gerrit.osmocom.org/1938
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56ba0da61978bbdce71d0e320166c52b20b42517
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list