[PATCH] osmo-hlr[master]: logging

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/1954

logging

Change-Id: I0ffbfa8d32dce19133c71389b78833713c60b923
---
M src/gsup_router.c
M src/hlr.c
M src/luop.c
3 files changed, 20 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/54/1954/1

diff --git a/src/gsup_router.c b/src/gsup_router.c
index e9aed78..fbc22fc 100644
--- a/src/gsup_router.c
+++ b/src/gsup_router.c
@@ -22,8 +22,10 @@
 
 #include <osmocom/core/linuxlist.h>
 #include <osmocom/core/talloc.h>
+#include <osmocom/core/logging.h>
 
 #include "gsup_server.h"
+#include "logging.h"
 
 struct gsup_route {
 	struct llist_head list;
@@ -40,8 +42,11 @@
 
 	llist_for_each_entry(gr, &gs->routes, list) {
 		if (talloc_total_size(gr->addr) == addrlen &&
-		    !memcmp(gr->addr, addr, addrlen))
+		    !memcmp(gr->addr, addr, addrlen)) {
+			DEBUGP(DMAIN, "Found route to addr %s: %s:%u\n",
+			       addr, gr->conn->conn->addr, gr->conn->conn->port);
 			return gr->conn;
+		}
 	}
 	return NULL;
 }
@@ -64,6 +69,9 @@
 	gr->conn = conn;
 	llist_add_tail(&gr->list, &conn->server->routes);
 
+	DEBUGP(DMAIN, "New GSUP route: addr %s to %s:%u\n",
+	       gr->addr, gr->conn->conn->addr, gr->conn->conn->port);
+
 	return 0;
 }
 
@@ -80,6 +88,8 @@
 			num_deleted++;
 		}
 	}
+	DEBUGP(DMAIN, "Deleted all %u GSUP routes to %s:%u\n",
+	       num_deleted, conn->conn->addr, conn->conn->port);
 
 	return num_deleted;
 }
diff --git a/src/hlr.c b/src/hlr.c
index d74d9fb..98baf7e 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -143,6 +143,7 @@
 			  const struct osmo_gsup_message *gsup)
 {
 	struct lu_operation *luop = lu_op_alloc_conn(conn);
+	DEBUGP(DMAIN, "%s: Rx Update Location Request\n", gsup->imsi);
 	if (!luop) {
 		LOGP(DMAIN, LOGL_ERROR, "LU REQ from conn without addr?\n");
 		return -EINVAL;
@@ -244,6 +245,10 @@
 		return rc;
 	}
 
+	DEBUGP(DMAIN, "Rx from %s:%u msg %s\n",
+	       conn->conn->addr, conn->conn->port,
+	       osmo_hexdump_nospc(msg->data, msg->len));
+
 	switch (gsup.message_type) {
 	/* requests sent to us */
 	case OSMO_GSUP_MSGT_SEND_AUTH_INFO_REQUEST:
diff --git a/src/luop.c b/src/luop.c
index b0028da..e3126cd 100644
--- a/src/luop.c
+++ b/src/luop.c
@@ -54,6 +54,8 @@
 	msg_out = msgb_alloc_headroom(1024+16, 16, "GSUP LUOP");
 	osmo_gsup_encode(msg_out, gsup);
 
+	DEBUGP(DMAIN, "%s: Tx %s\n",
+	       gsup->imsi, osmo_gsup_message_type_name(gsup->message_type));
 	if (luop->conn)
 		osmo_gsup_addr_send_direct(luop->gsup_server,
 					   luop->conn,
@@ -167,7 +169,8 @@
 
 	conn = gsup_route_find(gs, addr, addrlen);
 	if (!conn) {
-		DEBUGP(DMAIN, "Cannot find route for addr %s\n", addr);
+		LOGP(DMAIN, LOGL_INFO, "Cannot find route for addr %s\n",
+		     addr);
 		msgb_free(msg);
 		return -ENODEV;
 	}

-- 
To view, visit https://gerrit.osmocom.org/1954
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ffbfa8d32dce19133c71389b78833713c60b923
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>