This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/1895/2/src/ctrl/control_cmd.c File src/ctrl/control_cmd.c: Line 49: { CTRL_TYPE_UNKNOWN, NULL } 2 things: have you tested that having NULL in here works? AFAIK this would be the first time that we store NULL as value in a value string. Should probably be verified in a unit test... missing termination with {0, NULL}: get_value_string() and get_string_value() don't know where the array ends. -- To view, visit https://gerrit.osmocom.org/1895 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd4e96dd9f00876cb70b43cfcf42ab4f10311b28 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes