[PATCH] osmo-bts[master]: measurement: initalize lchan properly

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Mon Jun 26 16:32:10 UTC 2017


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/2931

to look at the new patch set (#2).

measurement: initalize lchan properly

When the TX channel is activated, the measurement related struct
members are not properly reset. To ensure all flags are initalized
properly we set the measurement related flags zu zero.

This commit depends on openbsc change:
Change-Id I2ed78a9dd8747736d01ccf700396d7996f9f4e5d

(Patch by Octasic Inc.)

Change-Id: I02edc4724f3d272905bee13384628aca18ea9781
---
M src/common/rsl.c
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/2931/2

diff --git a/src/common/rsl.c b/src/common/rsl.c
index eab9379..5972c15 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -590,8 +590,13 @@
 	rsl_dch_push_hdr(msg, RSL_MT_CHAN_ACTIV_ACK, chan_nr);
 	msg->trx = lchan->ts->trx;
 
-	/* since activation was successful, do some lchan initialization */
+	/* since activation was successful, do some
+	 * lchan initialization for measurement */
 	lchan->meas.res_nr = 0;
+	lchan->meas.flags = 0;
+	lchan->meas.num_ul_meas = 0;
+	lchan->meas.num_sacch_bfi = 0;
+	lchan->meas.num_tch_bfi = 0;
 
 	return abis_bts_rsl_sendmsg(msg);
 }

-- 
To view, visit https://gerrit.osmocom.org/2931
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02edc4724f3d272905bee13384628aca18ea9781
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list