libosmo-sccp[master]: add various debug logging to help figure out complex SCCP ro...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Jun 25 18:47:12 UTC 2017


Patch Set 1:

(7 comments)

This patch came to be as I was hacking around to quickly see which code paths are being taken, hence I didn't put much thought in the individual log statements. All the more thanks for the detailed review! Update coming up...

https://gerrit.osmocom.org/#/c/3012/1//COMMIT_MSG
Commit Message:

Line 7: add various debug logging to help figure out complex SCCP routing
> actually, I think we only implement MTP-level routing so far.
I'll believe you right away, I don't know the landscape of acronyms in libosmo-sccp...


https://gerrit.osmocom.org/#/c/3012/1/src/m3ua.c
File src/m3ua.c:

Line 562: 		"m3ua data hdr opc=%u dpc=%u\n",
> I think the function name or some other indication should be given to indic
technically that's above in line 539; but true


https://gerrit.osmocom.org/#/c/3012/1/src/osmo_ss7.c
File src/osmo_ss7.c:

Line 745: 		DEBUGP(DLSS7, "Created route pc=%u mask=%u name=%s linkset %s\n", pc, mask, linkset_name,
> route creation/removal is rather rare, and it could actually be propagated 
I like that, yes


https://gerrit.osmocom.org/#/c/3012/1/src/osmo_ss7_hmrt.c
File src/osmo_ss7_hmrt.c:

Line 135: 		DEBUGP(DLSS7, "found route for dpc %u: %s pc=%u mask=%u %s:%s\n", dpc,
> point-codes can be printing in a more meaningful representation than as uns
interesting, so far I thought a PC *is* just an unsigned int. I'll take a look...


Line 152: 				DEBUGP(DLSS7, "rt->dest.as proto is M3UA for dpc %u\n", dpc);
> if you want to print this, I think it should go one level up and print for 
ack


Line 184: 		DEBUGP(DLSS7, "dpc %u is local\n", dpc);
> again I think here it's useful to see the context, i.e. that we just receiv
ack


https://gerrit.osmocom.org/#/c/3012/1/src/sccp_scoc.c
File src/sccp_scoc.c:

PS1, Line 1547: c
> could move into sccp_scoc_rx_inval_src_ref() and could be propagated from d
ah sure


-- 
To view, visit https://gerrit.osmocom.org/3012
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3243606d6cad7721f7da7f6caba2caa90ae2bbd
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list