[PATCH] osmo-bts[master]: TRX: don't free l1h in trx_phy_inst_close()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Jun 24 16:48:36 UTC 2017


Review at  https://gerrit.osmocom.org/3043

TRX: don't free l1h in trx_phy_inst_close()

l1h is allocated in bts_model_phy_instance_set_defaults() and not in
trx_phy_inst_open().  Hence, trx_phy_inst_close() should not free() it!

Change-Id: I0ac4e57a882e5a31143499c1662d8d8e52320938
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/43/3043/1

diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c
index c56efbf..8ce2893 100644
--- a/src/osmo-bts-trx/trx_if.c
+++ b/src/osmo-bts-trx/trx_if.c
@@ -629,7 +629,6 @@
 
 	trx_if_close(l1h);
 	trx_sched_exit(&l1h->l1s);
-	talloc_free(l1h);
 }
 
 /*! open the control + burst data sockets for one phy_instance */

-- 
To view, visit https://gerrit.osmocom.org/3043
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ac4e57a882e5a31143499c1662d8d8e52320938
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list