[MERGED] libosmo-sccp[master]: Revert "configure.ac: Use -Werror in C(PP)FLAGS"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jun 22 21:35:12 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: Revert "configure.ac: Use -Werror in C(PP)FLAGS"
......................................................................


Revert "configure.ac: Use -Werror in C(PP)FLAGS"

As discussed in chat, -Werror should not be enabled by default.
Instead it should be added in our jenkins build scripts.

This reverts commit fc252ca38427bf77e55fd272a954dfe24f03a719.

Change-Id: I92955c2f74f9a5c40e80028459100cf5e79a537b
---
M configure.ac
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Max: Looks good to me, but someone else must approve
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/configure.ac b/configure.ac
index 3c498c8..36cbb59 100644
--- a/configure.ac
+++ b/configure.ac
@@ -53,8 +53,8 @@
 CFLAGS="$saved_CFLAGS"
 AC_SUBST(SYMBOL_VISIBILITY)
 
-CFLAGS+=" -Wall -Werror"
-CPPFLAGS+=" -Wall -Werror"
+CFLAGS+=" -Wall"
+CPPFLAGS+=" -Wall"
 
 AC_OUTPUT(
     libosmo-sigtran.pc

-- 
To view, visit https://gerrit.osmocom.org/3010
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92955c2f74f9a5c40e80028459100cf5e79a537b
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list