libosmocore[master]: Add and use macros to set/get/clear/toggle bit flags

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Jun 22 06:34:55 UTC 2017


Patch Set 3: Code-Review-1

I'm not sure if this is really useful.  Actually, to me, you are hiding what the code does.  Every c programmer knows what  "foo & (1 << bit)" means.  By introducing "non-standard" syntax for such basic operations, I think you're actually making code harder to read.  With that kind of argument, we could also be adding macros like OSMO_INC(x) instead of "x += 1" ...

-- 
To view, visit https://gerrit.osmocom.org/2857
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d38b837ce84649c2975dbe8b889fe3a769885f
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-HasComments: No



More information about the gerrit-log mailing list