libosmo-sccp[master]: sccp: add addressbook functionality for sccp addresses

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jun 21 13:59:55 UTC 2017


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/#/c/2924/7/src/osmo_ss7_vty.c
File src/osmo_ss7_vty.c:

Line 1250: 	memcpy(ip_addr_backup,&entry->addr.ip,sizeof(entry->addr.ip));
space, space, space. Please consider instructing your editor to do this for you, if you don't do this automatically.  No need to spend time and attention on this, if it can be automatized.  I see it quite frequently in your patches, but don't want to keep making a fuzz about it. Thanks!


-- 
To view, visit https://gerrit.osmocom.org/2924
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I068ed7f7d113dab88424a9d47bab7fc703bb7942
Gerrit-PatchSet: 7
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list