libosmocore[master]: gsm0808: add default speech codec configuration

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jun 19 17:24:25 UTC 2017


Patch Set 6: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/2829/6/include/osmocom/gsm/protocol/gsm_08_08.h
File include/osmocom/gsm/protocol/gsm_08_08.h:

Line 459: 	 *  Configurations for the Adaptive Multi-Rate Codec Types */
As I said before: move this block up into the main API doc comment above, otherwise this is associated directly and only with GSM0808_SC_CFG_DEFAULT_FR_AMR. I know you want to associate this with three items, but that's not how doxygen works. Since you're explicitly naming them, it's fine to have it in the enum's global description.


Line 464: 	/*! Default values for FR_AMR_WB, OFR_AMR_WB and OHR_AMR_WB:
same


-- 
To view, visit https://gerrit.osmocom.org/2829
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dc0165d76a022b2c1b7418bc3133407e61b7261
Gerrit-PatchSet: 6
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list